fix: fix npm alias present in requires of dependencies #5703
+9
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In my project, i have a dependencies of a dependencies of a dependencies ... that have an alias :
So in the the package-lock.json i have this in the dependencies section :
The call of the API with the payload return me that the dependencie tree is invalid
As alias (npm:*) is removed from requires of a npm project with the method
NodePackageAnalyzer.shouldSkipDependency
, the dependencies tree reference missing package.My modifcation add a test to remove this alias too.
Fixes Issue
Maybe #3717
Description of Change
The change is to add in the requires section of the dependencies of dependencies the same filter that for other dependencies.
Have test cases been added to cover the new functionality?
no